Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImathTest: Fix build in mingw #232

Closed
wants to merge 1 commit into from
Closed

ImathTest: Fix build in mingw #232

wants to merge 1 commit into from

Conversation

Biswa96
Copy link

@Biswa96 Biswa96 commented Jan 27, 2022

No description provided.

@linux-foundation-easycla
Copy link

CLA Not Signed

Check _WIN32 instead of _MSC_VER, the later one is for MSVC only.

Signed-off-by: Biswapriyo Nath <[email protected]>
Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, these do look platform specific, rather than compiler specific

@meshula
Copy link
Contributor

meshula commented Jan 27, 2022

Thanks for the fix! And also, please have a look at the CLA/DCO requirements the project has.

@Biswa96
Copy link
Author

Biswa96 commented Jan 28, 2022

Please forgive me. I have opened the link that the bot provided. It opens a legal document of which I do not understand a single line. Also it asks too much of my personal information. I am not willing to give those information to a company just for this simple code change. Feel free copy my provided change here 🙏

@meshula
Copy link
Contributor

meshula commented Jan 28, 2022

Thanks for letting us know about your hesitation. I have created a bug report

#233

where I give you credit for identifying the problem, so we can resolve the problem through the bug reporting mechanism.

@cary-ilm
Copy link
Member

Closing this, we will provide the fix in a separate PR shortly, thanks.

@cary-ilm cary-ilm closed this Feb 12, 2022
@Biswa96 Biswa96 deleted the fix-test-mingw branch February 12, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants