Update ComfyUI #451

PassiveLemon · 2023-05-06T15:25:50Z

Just updated ComfyUI to Pytorch 2, Xformers 0.0.20, and the latest Comfy commit. I updated the Docker-compose accordingly.
This also fixes an issue where the mount for the output is not loaded so the container will not save images to a host mounted directory.

I found zero change with and without Triton so I just removed it.

The volume mount for output needs to be present or else ComfyUI will not save images to a host mounted directory.

Fixes error about not having permission to execute entrypoint.sh

AbdBarho · 2023-05-07T09:13:09Z

This also fixes an issue where the mount for the output is not loaded so the container will not save images to a host mounted directory.

hmmm, weird, I did not have this problem.

I found zero change with and without Triton so I just removed it.

triton now is now automatically installed with pytorch 2.

PassiveLemon · 2023-05-07T13:38:05Z

This also fixes an issue where the mount for the output is not loaded so the container will not save images to a host mounted directory.

hmmm, weird, I did not have this problem.

If you use a "save image" node, it automatically saves to the output folder? It does not for me. It will only work if I specifically add that docker mount.

PassiveLemon · 2023-05-07T13:58:33Z

This is mostly temporary but I pushed it so you can get the idea. I am now currently working on making custom nodes much easier to install.
If there is any directory in the custom_nodes path, it will get searched for a requirements.txt and then be installed. Sometimes they require distro specific packages like cmake so those might also need to get installed in this stage but I don't currently have a way to automatically fetch those which is the main issue here I also don't like doing this in the entrypoint since it will try to install the packages every single rebuild.
Currently, I just put Debian's build-essential package there because it contains a lot of the things nodes might need but extra stuff can always just be added to that line. Still thinking of different solutions so maybe you might have an idea that you like. A separate file for only distro packages could be added for easy user interaction but I'd like to avoid mostly empty stray files. They could also be loaded and installed in the Dockerfile using a similar method but again, its another stray file.
The method at this point is functional, though not ideal in my opinion.

Wont error from a file that doesn't exist

AbdBarho · 2023-05-08T17:24:22Z

Yeah extensions are weird, same situation is for auto. I had to specifically create a startup.sh script so users can put all of their stuff there, usually installing dependencies.

That being said, pip is smart enough to not re-install everything, only missing stuff.

Do you think a startup.sh script is a good solution?

AbdBarho · 2023-05-08T17:18:25Z

services/comfy/entrypoint.sh

@@ -44,4 +44,16 @@ for to_path in "${!MOUNTS[@]}"; do
  echo Mounted $(basename "${from_path}")
 done

+if [ "$(ls -A /stable-diffusion/custom_nodes)" ]; then
+  chmod 777 -R "/stable-diffusion/custom_nodes/"
+  apt-get install build-essential -y


we could move this into the dockerfile, where we install aria2 and others

AbdBarho · 2023-05-08T17:18:34Z

services/comfy/entrypoint.sh

@@ -44,4 +44,16 @@ for to_path in "${!MOUNTS[@]}"; do
  echo Mounted $(basename "${from_path}")
 done

+if [ "$(ls -A /stable-diffusion/custom_nodes)" ]; then
+  chmod 777 -R "/stable-diffusion/custom_nodes/"


why is this necessary?

Testing reasons. I wasn't going to bother fixing everything until there was a proposed solution

AbdBarho · 2023-05-08T17:20:33Z

services/comfy/entrypoint.sh

+  for dir in "/stable-diffusion/custom_nodes/*"; do
+    if [ -e "$dir/requirements.txt" ]; then
+      echo $dir
+      cd $dir
+      pip install -r requirements.txt
+    fi
+  done


I think we could simplify this loop

shopt -s nullglob list=(${ROOT}/custom_nodes/*/requirements.txt) for req in "${list[@]}"; do pip install -r "$req" done

AbdBarho · 2023-05-08T17:25:03Z

docker-compose.yml

+    volumes:
+      - *v2


This is already mounted in the x-base-service, so there is no need to change the mounts here.

That's the issue though. I know it's present in the base, but the save image node won't save the images to the hosts output directory unless it is present in the actual profile.

What is the output folder of the save image node? and does the output/comfy exist on your machine?

PassiveLemon · 2023-05-08T17:44:04Z

Yeah extensions are weird, same situation is for auto. I had to specifically create a startup.sh script so users can put all of their stuff there, usually installing dependencies.

That being said, pip is smart enough to not re-install everything, only missing stuff.

Do you think a startup.sh script is a good solution?

Maybe. It would definitely work, but it would really only be used for the Debian packages since the node pip dependencies would be included in their requirements.txt files. I'll quickly whip up a design and see how you like it

AbdBarho · 2023-05-12T18:27:08Z

docker-compose.yml

+    volumes:
+      - *v2


What is the output folder of the save image node? and does the output/comfy exist on your machine?

AbdBarho · 2023-05-12T18:29:35Z

services/comfy/entrypoint.sh

+shopt -s nullglob
+list=(${ROOT}/custom_nodes/*/requirements.txt)
+for req in "${list[@]}"; do
+  pip install -r "$req"
+done
+


I do still think this should be separate, otherwise it could introduce so many bugs we cannot account for.
i.e. we build the container with certain dependencies, yet at startup they get overwritten by random ones from the extensions.

An example which is very frustrating that comes to mind is opencv-headless.

The save image node doesn't have a path, just a name I set it to. It should save the image to the output/ folder in the comfyui directory. /output/comfy does exist on my system.

Would it be possible to create a whole separate pip environment for the extensions alone? I'm not familiar with it or python so I don't know if it's possible and how it would be done anyways.

AbdBarho · 2023-07-22T06:15:37Z

hey I am going to take the liberty and change some stuff do we can get this merged.

The auto install of custom node dependencies will be removed, but can still be added in a new PR.

Closes #451 --------- Co-authored-by: PassiveLemon <[email protected]>

Closes AbdBarho#451 --------- Co-authored-by: PassiveLemon <[email protected]>

PassiveLemon added 3 commits May 6, 2023 11:06

Update to Pytorch 2, Xformers 0.0.20, latest Comfy commit.

5477b88

Update DC

73f88f2

The volume mount for output needs to be present or else ComfyUI will not save images to a host mounted directory.

Restore execution privilege for entrypoint.sh

37150c5

Fixes error about not having permission to execute entrypoint.sh

Automated install of pip packages for nodes

1c129ee

PassiveLemon added 2 commits May 7, 2023 10:04

Conflict fix?

3849c48

Check if requirement.txt exists

17c44ca

Wont error from a file that doesn't exist

AbdBarho mentioned this pull request May 8, 2023

Update/fix mounts for comfyUI #432

Merged

AbdBarho reviewed May 8, 2023

View reviewed changes

Simplified requirement installing, startup.sh

89092c1

AbdBarho reviewed May 12, 2023

View reviewed changes

AbdBarho mentioned this pull request Jul 22, 2023

Comfy update and taesd and also medvram for a1111 #547

Open

AbdBarho mentioned this pull request Jul 22, 2023

Add startup script for comfy #552

Merged

AbdBarho closed this in #552 Jul 22, 2023

AbdBarho added a commit that referenced this pull request Jul 22, 2023

Add startup script for comfy (#552)

09a0f11

Closes #451 --------- Co-authored-by: PassiveLemon <[email protected]>

cloudaxes pushed a commit to cloudaxes/stable-diffusion-webui-docker that referenced this pull request Sep 6, 2023

Add startup script for comfy (AbdBarho#552)

11709e1

Closes AbdBarho#451 --------- Co-authored-by: PassiveLemon <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update ComfyUI #451

Update ComfyUI #451

PassiveLemon commented May 6, 2023

AbdBarho commented May 7, 2023

PassiveLemon commented May 7, 2023 •

edited

Loading

PassiveLemon commented May 7, 2023 •

edited

Loading

AbdBarho commented May 8, 2023

AbdBarho May 8, 2023

AbdBarho May 8, 2023

PassiveLemon May 8, 2023

AbdBarho May 8, 2023

AbdBarho May 8, 2023

PassiveLemon May 8, 2023 •

edited

Loading

AbdBarho May 12, 2023

PassiveLemon commented May 8, 2023 •

edited

Loading

AbdBarho May 12, 2023

AbdBarho May 12, 2023 •

edited

Loading

PassiveLemon May 12, 2023 •

edited

Loading

AbdBarho commented Jul 22, 2023 •

edited

Loading

Update ComfyUI #451

Update ComfyUI #451

Conversation

PassiveLemon commented May 6, 2023

AbdBarho commented May 7, 2023

PassiveLemon commented May 7, 2023 • edited Loading

PassiveLemon commented May 7, 2023 • edited Loading

AbdBarho commented May 8, 2023

AbdBarho May 8, 2023

Choose a reason for hiding this comment

AbdBarho May 8, 2023

Choose a reason for hiding this comment

PassiveLemon May 8, 2023

Choose a reason for hiding this comment

AbdBarho May 8, 2023

Choose a reason for hiding this comment

AbdBarho May 8, 2023

Choose a reason for hiding this comment

PassiveLemon May 8, 2023 • edited Loading

Choose a reason for hiding this comment

AbdBarho May 12, 2023

Choose a reason for hiding this comment

PassiveLemon commented May 8, 2023 • edited Loading

AbdBarho May 12, 2023

Choose a reason for hiding this comment

AbdBarho May 12, 2023 • edited Loading

Choose a reason for hiding this comment

PassiveLemon May 12, 2023 • edited Loading

Choose a reason for hiding this comment

AbdBarho commented Jul 22, 2023 • edited Loading

PassiveLemon commented May 7, 2023 •

edited

Loading

PassiveLemon commented May 7, 2023 •

edited

Loading

PassiveLemon May 8, 2023 •

edited

Loading

PassiveLemon commented May 8, 2023 •

edited

Loading

AbdBarho May 12, 2023 •

edited

Loading

PassiveLemon May 12, 2023 •

edited

Loading

AbdBarho commented Jul 22, 2023 •

edited

Loading