-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/fix mounts for comfyUI #432
Conversation
Fix `custom_nodes` path Move models for comfy from `/data/config/comfy` to `/data/config/comfy/models` Add paths for models: `diffusers`, `gligen`, `hypernetworks` Mode `clip`, `clip_vision` from cache to models, because it's model Add path for `input` Format script for reading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, we still need some tuning for this UI.
services/comfy/entrypoint.sh
Outdated
|
||
MOUNTS["${ROOT}/models/style_models"]="/data/config/comfy/models/style_models" | ||
MOUNTS["${ROOT}/models/t2i_adapter"]="/data/config/comfy/models/t2i_adapter" | ||
MOUNTS["${ROOT}/models/clip"]="/data/config/comfy/models/clip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this any different from the standard clip model provided by the transformers packages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think yes
services/comfy/entrypoint.sh
Outdated
MOUNTS["${ROOT}/models/clip"]="/data/config/comfy/models/clip" | ||
MOUNTS["${ROOT}/models/clip_vision"]="/data/config/comfy/models/clip_vision" | ||
MOUNTS["${ROOT}/models/gligen"]="/data/config/comfy/models/gligen" | ||
MOUNTS["${ROOT}/models/diffusers"]="/data/config/comfy/models/diffusers" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here?
I didn't really understand you, but comfyUI has nodes that use these models:
|
@AbdBarho Did I make myself clear? |
I will try to test the clip model and others tomorrow, then we can merge this PR, sorry for the delay. |
What was broken about these? I never had to use them so I don't really know |
I changed the solution to something a bit more maintainable. The commented lines are stuff I was not able to test, so I will delay for now. If you have examples of how I can test this stuff, hmu. |
@PassiveLemon It was impossible to add custom nodes, or for example load your own |
@AbdBarho I don't think It may be more convenient to use
|
Thank you! I will try this example and see what need to be changed. |
This actually means a lot to me. I was just working on a way to make nodes easier to install by automatically installing their requirements.txt when put into the custom_nodes directory. This would explain why it wasn't working, because now it does work lol |
So the I created #458 for clip, I am unfortunately still unsure about the remaining stuff, I will checkout #451 next I will try to find more examples for the remaining missing mounts, just so I can test them and integrate them. |
I updated the paths to make all paths work Now paths in ComfyUI are working Added: - `input` - `models/configs` - `models/gligen` - `models/diffusers` - `models/hypernetworks` Was broken: - `custom_nodes` - `models/clip_vision` - `models/clip` --------- Co-authored-by: LEv145 <[email protected]> Co-authored-by: AbdBarho <[email protected]>
I updated the paths to make all paths work Now paths in ComfyUI are working Added: - `input` - `models/configs` - `models/gligen` - `models/diffusers` - `models/hypernetworks` Was broken: - `custom_nodes` - `models/clip_vision` - `models/clip` --------- Co-authored-by: LEv145 <[email protected]> Co-authored-by: AbdBarho <[email protected]>
I updated the paths to make all paths work
Now paths in ComfyUI are working
Added:
input
models/configs
models/gligen
models/diffusers
models/hypernetworks
Was broken:
custom_nodes
models/clip_vision
models/clip