Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Edit and EditUser #285

Merged
merged 2 commits into from
Nov 11, 2023
Merged

Fix Edit and EditUser #285

merged 2 commits into from
Nov 11, 2023

Commits on Nov 11, 2023

  1. Fix Edit and EditUser 

    Edit and EditUser does not check for duplicate phone numbers
and emails. Add, Edit, and EditUser also did not check if numbers
and emails were the same as the user.

Fix Edit and EditUser commands with guard clauses checking for
duplicate phones.
Fix hasPhone, hasEmail, and hasPerson to include user in its checks.
Add tests checking for duplicate emails and numbers to both edit commands.
Add overloaded methods in EditPersonDescriptorBuilder and
EditUserDescriptorBuilder
    @owenyeo
    owenyeo committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    4aa153d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into v1.4-fixedit-0 

    Fix merge issues
    @owenyeo
    owenyeo committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    06b50d4 View commit details
    Browse the repository at this point in the history