Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Edit and EditUser #285

Merged
merged 2 commits into from
Nov 11, 2023

Conversation

owenyeo
Copy link

@owenyeo owenyeo commented Nov 11, 2023

Edit and EditUser does not check for duplicate phone numbers and emails. Add, Edit, and EditUser also did not check if numbers and emails were the same as the user.

Fix Edit and EditUser commands with guard clauses checking for duplicate phones.
Fix hasPhone, hasEmail, and hasPerson to include user in its checks. Add tests checking for duplicate emails and numbers to both edit commands. Add overloaded methods in EditPersonDescriptorBuilder and EditUserDescriptorBuilder

Edit and EditUser does not check for duplicate phone numbers
and emails. Add, Edit, and EditUser also did not check if numbers
and emails were the same as the user.

Fix Edit and EditUser commands with guard clauses checking for
duplicate phones.
Fix hasPhone, hasEmail, and hasPerson to include user in its checks.
Add tests checking for duplicate emails and numbers to both edit commands.
Add overloaded methods in EditPersonDescriptorBuilder and
EditUserDescriptorBuilder
@owenyeo owenyeo added this to the v1.4 milestone Nov 11, 2023
@owenyeo owenyeo self-assigned this Nov 11, 2023
@owenyeo owenyeo added bug Something isn't working severity.Medium Occasional inconvenience to some users but can continue to use the product labels Nov 11, 2023
Copy link

@kristayeo kristayeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u ate LGTM

@kristayeo kristayeo merged commit 7c1d5b8 into AY2324S1-CS2103T-W12-4:master Nov 11, 2023
0 of 3 checks passed
@owenyeo owenyeo deleted the v1.4-fixedit-0 branch November 13, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working severity.Medium Occasional inconvenience to some users but can continue to use the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants