Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included DS_Store files in .gitignore. #6161

Closed

Conversation

jerieljan
Copy link

DS_Store files are commonly ignored since they're generated by macOS, and frequently encountered by Mac developers.

Merging this should prevent them from being pushed by a Mac user contributor in the future and cluttering up their git status.

example:

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	.DS_Store
	.github/.DS_Store
	extensions-builtin/.DS_Store
	modules/.DS_Store
	test/.DS_Store

DS_Store files are commonly ignored since they're generated by
macOS, and frequently encountered by Mac developers.
@aliencaocao
Copy link
Contributor

aliencaocao commented Jan 1, 2023

#4534 (comment)

@jerieljan jerieljan closed this Jan 1, 2023
@jerieljan
Copy link
Author

Thanks for pointing that out. I appreciate it.
I personally disagree since I usually add them anyway (like here) to avoid stray edits, but that's fine.

@jerieljan jerieljan deleted the fix/ds_store_gitignore branch January 1, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants