Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac: Add .DS_Store to .gitignore #13652

Closed
wants to merge 1 commit into from
Closed

Conversation

antfu
Copy link
Contributor

@antfu antfu commented Oct 16, 2023

Description

close #8310

.DS_Store is a common file generated by Finder (File Explorer) in ever folder. It should be ignored in general.

Screenshots/videos:

Checklist:

@antfu antfu requested a review from AUTOMATIC1111 as a code owner October 16, 2023 05:46
@antfu antfu changed the base branch from master to dev October 16, 2023 05:50
@catboxanon
Copy link
Collaborator

Add it to .git/info/exclude. See also: #4534 #6161 #10369 #13612

@catboxanon catboxanon closed this Oct 16, 2023
@antfu
Copy link
Contributor Author

antfu commented Oct 17, 2023

I wonder what's the reason not having one line of code to make the sensible default, instead of asking every mac user to exclude that manually? .DS_Store is ignored in the majority of OSS projects.

@ShinChven
Copy link

I wonder what's the reason not having one line of code to make the sensible default, instead of asking every mac user to exclude that manually? .DS_Store is ignored in the majority of OSS projects.

Totally agreed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add residual files to .gitignore that should be ignored on a Mac
3 participants