Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update max32660 sdk files #15421

Merged
merged 2 commits into from
May 25, 2023
Merged

Update max32660 sdk files #15421

merged 2 commits into from
May 25, 2023

Conversation

polat-ahmet
Copy link
Contributor

@polat-ahmet polat-ahmet commented May 11, 2023 •
edited
Loading

Summary of changes

Update MAX32660 SDK driver files to get final updates and fixes.

Impact of changes

Migration actions required

Documentation

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR

ARMC6_TEST_RESULT.txt
GCC_TEST_RESULT.txt

Reviewers

@ozersa

@polat-ahmet polat-ahmet marked this pull request as ready for review May 11, 2023 15:10
@0xc0170 0xc0170 requested a review from a team May 12, 2023 11:11
ozersa
ozersa approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@ozersa ozersa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved,
There are two commits, please keep history as it is.
Do not apply squash merge.

@ozersa
Copy link
Contributor

ozersa commented May 15, 2023

@0xc0170 could you add @polat-ahmet in MaximTeams too.

@0xc0170
Copy link
Contributor

0xc0170 commented May 16, 2023

@0xc0170 could you add @polat-ahmet in MaximTeams too.

Done

0xc0170
0xc0170 previously approved these changes May 16, 2023
View reviewed changes
@0xc0170
Copy link
Contributor

0xc0170 commented May 16, 2023

CI started

@0xc0170 0xc0170 added needs: CI release-type: patch Indentifies a PR as containing just a patch and removed needs: review labels May 16, 2023
@mbed-ci
Copy link

mbed-ci commented May 17, 2023

Jenkins CI Test : ❌ FAILED

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ❌
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ❌

@mergify mergify bot added needs: work and removed needs: CI labels May 17, 2023
@ozersa
Apply MAX32660 delta
d42b9b3 
Update mbed hal function as per of SDK update

Signed-off-by: Sadik.Ozer <[email protected]>
@mergify mergify bot dismissed 0xc0170’s stale review May 17, 2023 08:24

Pull request has been modified.

@ozersa
Copy link
Contributor

ozersa commented May 17, 2023

I restarted CI but I believe this is valid failure:

Number of failures = 0
find . -name *.elf ! -path *wifi* ! -path *atecc608a* ! -path *lorawan* | xargs -I % python ../mbed-os/tools/test/examples/elf_float_checker.py %
Checking ./mbed-os-example-blinky/BUILD/MAX32660EVSYS/GCC_ARM/mbed-os-example-blinky.elf for floating point symbols
Failed - Found float symbols:
__aeabi_f2d
__aeabi_dsub
__aeabi_i2d
__aeabi_drsub
__aeabi_ul2d
__aeabi_dmul
__aeabi_d2f
__aeabi_dadd
__aeabi_ui2d
__aeabi_l2d
__aeabi_ddiv
Found float symbols in ./mbed-os-example-blinky/BUILD/MAX32660EVSYS/GCC_ARM/mbed-os-example-blinky.elf

look at artifacts ('artifacts/15421/1/build-example-GCC_ARM/FAIL/MAX32660EVSYS/'), there's log to contain details

I believe it is fixed, could you rerun it,
Again history is important please do not apply squash merge.

@0xc0170
Copy link
Contributor

0xc0170 commented May 22, 2023

CI started

@mbed-ci
Copy link

mbed-ci commented May 22, 2023

Jenkins CI Test : ✔️ SUCCESS

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@ozersa
Copy link
Contributor

ozersa commented May 25, 2023

@0xc0170
Could it be merged?
Thanks

@0xc0170 0xc0170 merged commit 3a08a45 into ARMmbed:master May 25, 2023
@mergify mergify bot removed the ready for merge label May 25, 2023
@ozersa ozersa deleted the dev-update_max32660_sdk branch May 25, 2023 12:10
@multiplemonomials multiplemonomials mentioned this pull request Sep 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozersa ozersa ozersa approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-type: patch Indentifies a PR as containing just a patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@polat-ahmet @ozersa @0xc0170 @mbed-ci