ENH: Rename the csv module to prevent errors #788
Conversation
|
@mgrover1 Looks good to me, failing test seems to be an import error still, the doc build fail is strange as we don't pin sphinx, maybe because we pip install it in the enviromnet_docs.yml and its pip installing an earlier version? |
|
@mgrover1 Looks like pysp2 doc is failing due to sphinx as well, wonder if sphinx did an update... |
|
Yes, it is happening across the Pythia sphere as well |
|
@mgrover1 Ah makes sense.... yeah was digging through sphinx and couldn't find anything, can you reference one of the pythia issues here? |
|
see the discussion here ProjectPythia/cookbook-template#154 |
|
@mgrover1 Pushed an attempted fix commit for the path in noaapsl. Not sure why the path is failing there but not in neon.py etc. We might have to dig further on the cause. |
|
@mgrover1 found the problem think its fixed. |
|
Surprised that didn't fix the issue... |
|
@zssherman - the |
|
@mgrover1 I added in the noaa psl change to test it out, but the init change was missing text instead of csv for the top module. Thought that would have fixed the issue when I changed that |
|
It would help if the submodule were actually added... that last push should resolve the issues 👍 |
|
@rcjackson - this is a solid state now - do you have the PR ready to merge or do a release of PySP2 |
|
New release of PySP2 is out on PyPI, so once that gets through these unit tests should succeed. PySP2's are succeeding on my machine with @mgrover1 's fork installed though currently failing online because this PR and release is not done. |
|
@zssherman would you want to get a new release done today? |
|
@AdamTheisen Yeah, I can do that! |
|
@AdamTheisen An issue with the PySP2 release, going to get that fix, then can do the ACT release |
|
Can I hit merge? |
|
@mgrover1 Yep was waiting on pysp2 to catch up! |
Rename the csv module to text