-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename CSV submodule #787
Comments
@mgrover1 I would be fine with that, we would just need to reach out to the DQ folks etc. It should not change the import path if act.io.read_csv is used, but i know sometimes act.io.csv. has been used. So would have to make sure it doesn't break anything. I post in the act channel |
I would be okay changing it to act.io.text since it really can do more than just csv |
I agree here @AdamTheisen !! I can draft up a PR. |
@AdamTheisen @mgrover1 Sounds good! I say yeah, submit the PR and we'll greenlight once we get the ok from the DQ folks |
PySP2 will need an update as well here (cc @rcjackson ) |
Just let me know what is decided for the new name then I can push a micro-release. |
|
@mgrover1 Can we drop the second import path/reference as we're importing read_csv in the init? |
Description
We should consider renaming the
act.io.csv
submodule in ACT. It will lead to import issues with pandas, as it is not recommended to have modules titledcsv
see the thread here
We can still keep the same API -
read_csv
, but we should rename to something like "text" or "tabular". Thoughts?What I Did
Upon submitting a PR, the following error appeared:
The text was updated successfully, but these errors were encountered: