misc(core-blockchain): log the reason for discarding a block #2903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When processing blocks, if we find that some block is not chained then we abandon the rest of the blocks. In this case, print a detailed message explaining that a block is not chained and why. Without this printout sync failures could be very obscure and difficult to analyze.
vasild
requested review from
air1one,
faustbrian,
kristjank and
spkjp
as code owners
|
Your pull request doesn't follow our contribution guidelines. Please review and correct it. |
ghost
added
the
Codecov Report
@@ Coverage Diff @@
## develop #2903 +/- ##
===========================================
- Coverage 68.17% 67.76% -0.42%
===========================================
Files 406 424 +18
Lines 9767 9932 +165
Branches 507 512 +5
===========================================
+ Hits 6659 6730 +71
- Misses 3067 3158 +91
- Partials 41 44 +3
Continue to review full report at Codecov.
|
18 tasks
spkjp
suggested changes
Sep 3, 2019
|
Your pull request needs some changes. Please wait for a comment from one of our developers for more information. |
spkjp
changed the title
Co-Authored-By: supaiku <[email protected]>
…k-chained-verbose * ArkEcosystem/core/develop: test: mock missing wsServer release: 2.5.24 (#2908) fix(core-p2p): terminate blocked client connections fix(core-p2p): drop connections with malformed messages fix(core-api): return block timestamp for v2 transactions (#2906) fix(core-blockchain): only shift milestoneHeights[] if at that height (#2904) fix(crypto): use `anyOf` for transactions schema (#2894) fix(core-webhooks): cast params in condition checks (#2887) feat(core-p2p): use compression on the p2p level (#2886)
This would make us try to download the block at the same height again from a different peer. Also, check if the block being tested for isBlockChained() is in the list of exceptions and if so, assume the check has passed.
…k-chained-verbose * ArkEcosystem/core/develop: refactor(core-p2p): share rate limiter between workers (#2912)
spkjp
approved these changes
Sep 6, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing blocks, if we find that some block is not chained then
we abandon the rest of the blocks. In this case, print a detailed
message explaining that a block is not chained and why.
Without this printout sync failures could be very obscure and difficult
to analyze.
A summary of what changes this PR introduces and why they were made.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
developbranch, not themasterbranchIf adding a new feature, the PR's description includes: