Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verbatim password_encryption #470

Closed
wants to merge 13 commits into from
Closed

verbatim password_encryption #470

wants to merge 13 commits into from

Conversation

barda
Copy link

@barda barda commented Jan 30, 2020

For 11 copy password_encryption configuration variable: valid values are md5 and scram-sha-256

@egmont1227
Copy link
Contributor

duplicated by #460 and #368, i propose to close this one

@maglub
Copy link
Collaborator

maglub commented Jun 10, 2020

PR #460 has a suboptimal solution:

password_encryption = {{ 'md5' if postgresql_password_encryption != 'scram-sha-256' else 'scram-sha-256' }}     # md5 or scram-sha-256

I agree with the solution in this PR, but this PR touches too many other things:

password_encryption = {{ postgresql_password_encryption if postgresql_password_encryption else 'off' }}		# md5 or scram-sha-256

Valid values are:

  • ""
  • on
  • md5
  • scram-sha-256

@robustq
Copy link

robustq commented Feb 17, 2021

Can be closed as #460 was merged in, though @barda the privileges piece is interesting, and you should definitely consider moving those changes to another pull request

@egmont1227
Copy link
Contributor

egmont1227 commented Feb 24, 2021

Agree. Please adjust your changes to privileges only (merge master changes for password encryption) and rename this PR
or close this one and open another one for the privileges part.

seems to be some kind of duplicate of #505 and #181 and related to Issue #175

@gclough
Copy link
Collaborator

gclough commented Nov 17, 2021

@barda , thanks for the work, and based on the discussion above I will close this PR, but we would appreciate one specifically on the password fix.

If you can keep Pull Requests limited to only a single fix, then it makes them easier to approve/reject them individually.

@gclough gclough closed this Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants