-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct manage setting 'password_encryption' for PostgreSQL 10 and above #460
Conversation
@MemberIT , could you update this PR? |
…password_encryption
Done. |
@gclough can you merge this one please? It's a bug that the role was being plagued since 2018 and it's a simple fix. |
This PR has a suboptimal solution, as the allowed values are not correct. Why don't we just use a simple solution. We don't have to do the validity check in our role, we can leave it to the user (as we do for many other variables). Like in PR #460.
For PG11 and 12, valid values are:
|
@maglub |
Looks good to me, thanks a lot! Who do we chase to get this PR accepted? |
Correct manage setting 'password_encryption' for PostgreSQL 10 and above
PostgreSQL =< 9.6 password_encryption is boolean
https://www.postgresql.org/docs/9.6/runtime-config-connection.html
PostgreSQL >= 10 password_encryption is enum - 'md5' (default) or 'scram-sha-256'.
https://www.postgresql.org/docs/10/runtime-config-connection.html
Duplicates PR #368, but retains backward compatibility with versions below 10.