AMReX SoA Named Components #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
changed the title
ax3l
force-pushed
the
topic-upstream-soa-named
branch
from
d41d068 to
a3b79d3
Compare
2 tasks
ax3l
force-pushed
the
topic-upstream-soa-named
branch
from
a3b79d3 to
4add429
Compare
ax3l
commented
Jan 14, 2025
ax3l
commented
Jan 14, 2025
5 tasks
atmyers
pushed a commit
to AMReX-Codes/amrex
that referenced
this pull request
Jan 17, 2025
## Summary We forgot a `define()` that also needs to forward the names of SoA components. This fixes it. ## Additional background First seen in AMReX-Codes/pyamrex#382 ## Checklist The proposed changes: - [x] fix a bug or incorrect behavior in AMReX - [ ] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] include documentation in the code and/or rst files, if appropriate
ax3l
added a commit
to ax3l/pyamrex
that referenced
this pull request
Jan 17, 2025
Update to latest commit in `development`. Pull in fix AMReX-Codes/amrex#4298 for AMReX-Codes#382.
This was referenced Jan 17, 2025
ax3l
force-pushed
the
topic-upstream-soa-named
branch
from
4add429 to
6a66b61
Compare
atmyers
pushed a commit
to AMReX-Codes/amrex
that referenced
this pull request
Jan 21, 2025
## Summary Avoid user errors. Happened immediately to me: I added a runtime component with the same name as a compile-time SoA component and no error was thrown (now it will). ## Additional background AMReX-Codes/pyamrex#382 ## Checklist The proposed changes: - [x] fix a bug or incorrect behavior in AMReX - [ ] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] include documentation in the code and/or rst files, if appropriate
ax3l
added a commit
that referenced
this pull request
Jan 23, 2025
Update to latest commit in `development`. Pull in fixes - [x] AMReX-Codes/amrex#4298 - [x] AMReX-Codes/amrex#4299 - [x] AMReX-Codes/amrex#4302 - [x] AMReX-Codes/amrex#4300 for #382.
Replace our own named SoA particle components implementation with the now upstream support in AMReX.
ax3l
force-pushed
the
topic-upstream-soa-named
branch
from
6a66b61 to
0585d17
Compare
ax3l
commented
Jan 23, 2025
ax3l
commented
Jan 23, 2025
Signed-off-by: Axel Huebl <[email protected]>
|
@atmyers this PR and the ImpactX PR are ready for review :) |
atmyers
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace our own named SoA particle components implementation with the now upstream support in AMReX. Early draft, unfinished.
development#404