PC: SoA Name Helpers #4300
Merged
PC: SoA Name Helpers #4300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ax3l
force-pushed
the
topic-add-name-helpers
branch
from
5486f1d to
306be86
Compare
|
@atmyers rebased and ready for review :) |
This was referenced Jan 21, 2025
|
@WeiqunZhang I think the CI codespell issues are unrelated to this PR. |
Add name to index getters and query (has) functions to SoA names. Ported over from ImpactX.
ax3l
force-pushed
the
topic-add-name-helpers
branch
from
306be86 to
665434b
Compare
|
There is probably a new version of codespell. I will remove the check from required list. Then will try to fix it. |
|
Thanks! Yes looked like it just found new locations. PR ready for review :) |
atmyers
approved these changes
Jan 21, 2025
ax3l
added a commit
to AMReX-Codes/pyamrex
that referenced
this pull request
Jan 23, 2025
Update to latest commit in `development`. Pull in fixes - [x] AMReX-Codes/amrex#4298 - [x] AMReX-Codes/amrex#4299 - [x] AMReX-Codes/amrex#4302 - [x] AMReX-Codes/amrex#4300 for #382.
ax3l
added a commit
to AMReX-Codes/pyamrex
that referenced
this pull request
Jan 24, 2025
Replace our own named SoA particle components implementation with the now upstream support in AMReX. Early draft, unfinished. - [x] add new APIs from AMReX-Codes/amrex#4300 - [x] rebase after #404 --------- Signed-off-by: Axel Huebl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add name to index getters and query (has) functions to SoA names. Ported over from ImpactX.
Additional background
ECP-WarpX/impactx#805
Checklist
The proposed changes: