Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove NSE support from Strang #1542

Closed
zingale opened this issue May 7, 2024 · 0 comments
Closed

remove NSE support from Strang #1542

zingale opened this issue May 7, 2024 · 0 comments
Labels
integrator nse

Comments

@zingale
Copy link
Member

zingale commented May 7, 2024

Strang integration doesn't really allow us to evolve the NSE state to second-order accuracy. We should simply remove NSE as an option from Strang.
@zingale zingale mentioned this issue May 10, 2024
Merged
@zingale zingale added the nse label May 16, 2024
This was referenced Jul 9, 2024
Closed
Merged
zingale pushed a commit that referenced this issue Jul 11, 2024
@zhichen3
Update rhoX for nse_solver for SDC and discard strang (#1607)
4142d4f 
This is to address #1606 and partially addresses #1542

Also some clean-ups to nse-solver. It mainly stores state.y[SFS+n] at the end.
@zingale zingale closed this as completed Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
integrator nse
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zingale