Update rhoX for nse_solver for SDC and discard strang #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
overflow in hybrj |
zingale
approved these changes
Jul 9, 2024
|
Mostly just cleaning. I ended up storing state.y[SFS+n] after we solved NSE. |
zingale
reviewed
Jul 11, 2024
nse_solver/nse_solver.H
Outdated
| @@ -73,11 +73,12 @@ T get_nonexponent_nse_state(const T& state) { | |||
|
|
|||
| // find nse mass frac without the exponent term. | |||
|
|
|||
| amrex::Real power = 2.0 * M_PI * network::mion(n+1) * | |||
| C::k_B * T_in / (C::hplanck * C::hplanck); | |||
| constexpr amrex::Real ihplanck2 = 1.0_rt / (C::hplanck * C::hplanck); | |||
There was a problem hiding this comment.
this can be moved outside of the loop
zingale
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address #1606 and partially addresses #1542
Also some clean-ups to nse-solver. It mainly stores state.y[SFS+n] at the end.