Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch true-SDC to completely use burn_t internally in the Newton solve #2605

Merged
merged 5 commits into from
Oct 9, 2023
Merged

switch true-SDC to completely use burn_t internally in the Newton solve #2605

merged 5 commits into from
Oct 9, 2023

Conversation

zingale
Copy link
Member

@zingale zingale commented Oct 7, 2023

PR summary

this eliminates some excess memory and copies

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale zingale changed the title switch true-SDC to completely use burn_t internally in the Newton solve [WIP] switch true-SDC to completely use burn_t internally in the Newton solve Oct 7, 2023
@zingale
Copy link
Member Author

zingale commented Oct 7, 2023

this currently doesn't work for some reason

@zingale zingale changed the title [WIP] switch true-SDC to completely use burn_t internally in the Newton solve switch true-SDC to completely use burn_t internally in the Newton solve Oct 9, 2023
@zingale
Copy link
Member Author

zingale commented Oct 9, 2023

it seems like this works now that we've merged #2606

@zingale
Copy link
Member Author

zingale commented Oct 9, 2023

tests: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2023-10-09-006/index.html

@zingale zingale added the sdc label Oct 9, 2023
@zingale
Copy link
Member Author

zingale commented Oct 9, 2023

this closes #2564 and #2563

@zingale zingale merged commit b53d0d8 into AMReX-Astro:development Oct 9, 2023
18 checks passed
@zingale zingale deleted the switch_newton_to_burn_t branch October 9, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxpkatz maxpkatz maxpkatz approved these changes

Assignees
No one assigned
Labels
sdc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @maxpkatz