Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 4th order diffusion convergence + diffusion_test fixes #2592

Merged
merged 3 commits into from
Oct 5, 2023
Merged

fix 4th order diffusion convergence + diffusion_test fixes #2592

merged 3 commits into from
Oct 5, 2023

Conversation

zingale
Copy link
Member

@zingale zingale commented Oct 2, 2023 •
edited
Loading

PR summary

In the conversion from Fortran to C++, the order of and cell-centered T
diffusive flux was swapped.

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale zingale mentioned this pull request Oct 2, 2023
Closed
@zingale zingale changed the title [WIP] Some diffusion_test fixes fix 4th order diffusion convergence + diffusion_test fixes Oct 5, 2023
@zingale zingale merged commit af29792 into AMReX-Astro:development Oct 5, 2023
18 checks passed
@zingale zingale deleted the fix_4th_diffusion branch October 5, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxpkatz maxpkatz maxpkatz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @maxpkatz