Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4th order diffusion is not converging correctly #2593

Closed
zingale opened this issue Oct 2, 2023 · 5 comments
Closed

4th order diffusion is not converging correctly #2593

zingale opened this issue Oct 2, 2023 · 5 comments
Labels
sdc

Comments

@zingale
Copy link
Member

zingale commented Oct 2, 2023

Looking at the diffusion_test problem, and using the compilation fixes in PR #2592, we don't seem to be converging 4th order anymore. In particular, the errors are much larger than in the README.md for that problem setup.
@zingale zingale added the sdc label Oct 2, 2023
@zingale
Copy link
Member Author

zingale commented Oct 4, 2023

the issue happens between 20.05 and 20.06. This is right when we were converting lots of 4th order stuff to C++

@zingale
Copy link
Member Author

zingale commented Oct 4, 2023 •
edited
Loading

we also seem to work with a85c95b

@zingale
Copy link
Member Author

zingale commented Oct 4, 2023

okay, no surprise, the commit that breaks the convergence is 282df54

commit 282df547288a839a98dcacef33d57fcad7d8ae83
Author: Michael Zingale <[email protected]>
Date:   Mon May 25 16:10:52 2020 -0400

    port the 4th order avisc and diffusion to C++ (#995)

Source/hydro/Castro_fourth_order_nd.F90
Source/hydro/Castro_hydro.H
Source/hydro/Castro_hydro_F.H
Source/hydro/Castro_mol_hydro.cpp
Source/hydro/Make.package
Source/hydro/fourth_order.cpp

@zingale
Copy link
Member Author

zingale commented Oct 5, 2023

The order of the dT/dx computation for cell-centered vs. average T was wrong -- it was mixed up when converting from Fortran to C++.

The PR #2592 now gives the correct convergence

@zingale
Copy link
Member Author

zingale commented Oct 5, 2023

this has been fixed

@zingale zingale closed this as completed Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sdc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zingale