Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PySB import: Change default simplify to work with multiprocessing #1961

Merged
merged 2 commits into from
Jan 27, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jan 27, 2023

The lambda default argument cannot be pickled.

The lambda default argument cannot be pickled.
@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #1961 (892b732) into develop (32c5292) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1961   +/-   ##
========================================
  Coverage    76.01%   76.01%           
========================================
  Files           76       76           
  Lines        12982    12982           
========================================
  Hits          9868     9868           
  Misses        3114     3114           
Flag Coverage Δ
cpp 73.17% <ø> (ø)
petab 59.74% <ø> (ø)
python 69.00% <ø> (ø)
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/sdist/amici/pysb_import.py 94.62% <ø> (ø)
src/sundials_matrix_wrapper.cpp 80.61% <0.00%> (ø)

@dweindl dweindl requested a review from FFroehlich January 27, 2023 07:56
@dweindl dweindl requested a review from a team as a code owner January 27, 2023 08:16
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dweindl dweindl merged commit 4281010 into develop Jan 27, 2023
@dweindl dweindl deleted the fix_pysb_par_import branch January 27, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants