Steady state tolerance factor #1758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daniel Weindl <[email protected]>
…b.com/AMICI-dev/AMICI into feature_steady_state_tolerance_factor
Codecov Report
@@ Coverage Diff @@
## develop #1758 +/- ##
===========================================
- Coverage 78.01% 73.62% -4.39%
===========================================
Files 74 71 -3
Lines 12116 12050 -66
===========================================
- Hits 9452 8872 -580
- Misses 2664 3178 +514
Flags with carried forward coverage won't be shown. Click here to find out more.
|
* implement speedup dtotal_cldx_rdata, dx_rdatadx_solver * fixup flattening * fixup * speedup dwdx * simplify flattening * cleanup sbml import * Apply suggestions from code review Co-authored-by: Daniel Weindl <[email protected]> * fixup merge Co-authored-by: Daniel Weindl <[email protected]>
…b.com/AMICI-dev/AMICI into feature_steady_state_tolerance_factor
Adapt to separate sbml and pysb test suite (PEtab-dev/petab_test_suite#47)
|
Remaining PEtab test failure will be fixed by #1753 |
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1755, thanks for the feedback there.
operator==is left unchanged as it (practically) already covers the new settings [1]An alternative to these new settings would be to simply add a fixed multiplier e.g.
* 100.0at [2]I didn't test extensively, but a factor of
1e1was sufficient for the single problem I looked at. The default factors in this PR are set to1e2.[1] https://github.com/AMICI-dev/AMICI/blob/3d4975cd7fbffd9be588bc8b8f1e925590b3931f/src/solver.cpp#L500-L507=
[2] https://github.com/AMICI-dev/AMICI/blob/3d4975cd7fbffd9be588bc8b8f1e925590b3931f/src/solver.cpp#L796=