Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update petab test suite code #1768

Merged
merged 6 commits into from
Apr 7, 2022
Merged

Update petab test suite code #1768

merged 6 commits into from
Apr 7, 2022

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Apr 7, 2022

Adapt to separate sbml and pysb test suite (PEtab-dev/petab_test_suite#47)

@dweindl dweindl requested a review from dilpath April 7, 2022 14:51
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

else:
model_types = ['sbml', 'pysb']
argvalues = []
for format in ('sbml', 'pysb'):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"sbml" and "pysb" could be a constant (in petabtests.C)

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #1768 (8d9d4c0) into develop (4c3e6ad) will decrease coverage by 12.46%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #1768       +/-   ##
============================================
- Coverage    78.01%   65.54%   -12.47%     
============================================
  Files           74       30       -44     
  Lines        12115     4324     -7791     
============================================
- Hits          9451     2834     -6617     
+ Misses        2664     1490     -1174     
Flag Coverage Δ
cpp ?
petab 59.69% <75.00%> (-0.02%) ⬇️
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/amici/petab_import_pysb.py 92.45% <66.66%> (-0.89%) ⬇️
python/tests/test_petab_simulate.py 100.00% <100.00%> (ø)
python/amici/bngl_import.py 0.00% <0.00%> (-100.00%) ⬇️
python/amici/pandas.py 11.62% <0.00%> (-86.63%) ⬇️
python/amici/conserved_quantities_demartino.py 0.00% <0.00%> (-65.56%) ⬇️
python/amici/testing.py 0.00% <0.00%> (-50.00%) ⬇️
python/amici/swig_wrappers.py 59.32% <0.00%> (-35.60%) ⬇️
python/amici/pysb_import.py 60.60% <0.00%> (-33.94%) ⬇️
python/amici/import_utils.py 53.50% <0.00%> (-33.13%) ⬇️
python/amici/numpy.py 65.21% <0.00%> (-17.40%) ⬇️
... and 52 more

@dweindl dweindl merged commit 906bc1f into develop Apr 7, 2022
@dweindl dweindl deleted the update_petabtests branch April 7, 2022 15:14
dweindl added a commit that referenced this pull request Apr 7, 2022
Adapt to separate sbml and pysb test suite (PEtab-dev/petab_test_suite#47)
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants