Fix/did peer generation #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Ogenbertrand
requested changes
Dec 13, 2024
packages/multiple-did-identities/src/__tests__/generate-key-pair.spec.ts
Outdated
Show resolved
Hide resolved
|
Add tests for scenarios where invalid input is passed to generateKeyPairs, such as negative numbers or zero. |
Ogenbertrand
requested changes
Dec 13, 2024
packages/multiple-did-identities/src/__tests__/did-peer-2-service.spec.ts
Outdated
Show resolved
Hide resolved
packages/multiple-did-identities/src/__tests__/did-peer-3-service.spec.ts
Outdated
Show resolved
Hide resolved
|
It looks good! I added a comment that will be necessary to address so the did peers will be able to be used in further steps. (For packing the message, the id of the private key should have the previously shown format). Thank you! |
|
LGTM. |
|
It can be close after the response from @hugoib. |
IngridPuppet
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the required chnages to have the did:peer:generator work for our use case, it intoduces
Closes Fix did:peer generator #50