Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix did:peer generator #50

Closed
hugoib opened this issue Nov 29, 2024 · 10 comments · Fixed by #59
Closed

Fix did:peer generator #50

hugoib opened this issue Nov 29, 2024 · 10 comments · Fixed by #59
Assignees

Comments

@hugoib
Copy link
Collaborator

hugoib commented Nov 29, 2024

The did peer generator is not generating properly the keys and keys IDs

@hugoib hugoib self-assigned this Nov 29, 2024
@forkimenjeckayang forkimenjeckayang self-assigned this Nov 29, 2024
@hugoib
Copy link
Collaborator Author

hugoib commented Dec 2, 2024

Could not find a did:peer 2 generator that works, beyond the example of https://github.com/roots-id/didcomm-mediator

There is no library we could use for this... Still troubleshooting what is wrong with the current implementation, error might be on keys generator? still on it.

@nitch2019
Copy link

@hugoib and @forkimenjeckayang will sync to discuss the problem

@hugoib
Copy link
Collaborator Author

hugoib commented Dec 3, 2024

@nitch2019
Copy link

About my ticket, I’m still trying to match what is expected by the library vs what we are generating. My approach of the new secrets format is still failing I have one last idea to try. Since the error is inside the wasm rust library, it’s tricky to debug and the raised error might be on another place (?)

@hugoib
Copy link
Collaborator Author

hugoib commented Dec 6, 2024

I moved forward from the secrets issue but now I have a new one: Image

@hugoib
Copy link
Collaborator Author

hugoib commented Dec 6, 2024

For testing I am using an OOB inv from: https://mediator.rootsid.cloud

which resolves to:

Image

Apparently there is an error there where according to the spec serviceEndpoint should have a URI field Image

@hugoib
Copy link
Collaborator Author

hugoib commented Dec 6, 2024

Needs proper adjustments and cleanups as seen here: feat/update-oob-contact-routing-explore

@forkimenjeckayang
Copy link
Collaborator

forkimenjeckayang commented Dec 11, 2024

Pending PR to close this here:

@nitch2019
Copy link

PR will be reviewed by @hugoib

@Ogenbertrand Ogenbertrand self-assigned this Dec 12, 2024
@nitch2019
Copy link

@IngridPuppet pls review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants