-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add screen to spend expired swap-ins #564
Conversation
Funds that have not been swapped after 6 months can be spent by the wallet to any address.
3fdb159
to
1d39e0b
Compare
The user can now check the fee before broadcasting the refund transaction.
Cherry-picked I also added support for ACINQ/lightning-kmp#657. This PR makes the peer's client and watcher interfaces (i.e., may not always be In theory it means |
This PR adds a new screen accessible from the swap-in wallet view that lets users spend cancelled funds that have expired and are not eligible to be swapped to Lightning anymore.
Previously, users needed to perform a manual procedure to spend cancelled funds.
@robbiehanson if you have suggestions for the wording in the new screens, do not hesitate.
This PR depends on https://github.com/ACINQ/lightning-kmp/tree/spend-expired-swapin (not merged yet).
Android screens
Tapping on Cancelled funds opens the screen to spend the cancelled funds.
The address and the feerate are set by the user.
The amount cannot be modified. It depends on what is available in the wallet.
See:
peerManager.swapInWallet.readyForRefund.balance
.Low feerate check
Using a feerate below the mempool.space hour estimation triggers a "low feerate" warning, like for the splice-out screen (although unlike splice-outs, Phoenix cannot splice-CPFP that transaction later on, so the message is different and the acceleration part of it is removed).