-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parametric route search #844
Conversation
…restriction on the route size
# Conflicts: # eclair-core/src/main/scala/fr/acinq/eclair/router/Router.scala
# Conflicts: # eclair-core/src/main/scala/fr/acinq/eclair/payment/PaymentLifecycle.scala # eclair-core/src/main/scala/fr/acinq/eclair/router/Router.scala # eclair-core/src/test/scala/fr/acinq/eclair/integration/IntegrationSpec.scala
…ether router params into a config class
0bc2808
to
61e7174
Compare
# Conflicts: # eclair-core/src/main/resources/reference.conf # eclair-core/src/main/scala/fr/acinq/eclair/NodeParams.scala # eclair-core/src/test/scala/fr/acinq/eclair/TestConstants.scala
I propose the following change for the configuration parameters (names, description and units). What do you think @araspitzu?
|
I like them, path-finding is a good descriptive name. Mostly we want to make sure there is no confusion with other config keys (i.e max-cltv) and i think path-finding does a good job distinguishing them. Props for the fee threshold in satoshi too, it's a bit better now. |
Addressed comments in c9f93e2 |
This PR aims at enabling a narrower search for routes by exposing a set of parameters to limit the result and the search scope. Routes can now be 'requested' imposing a maximum number of hops, a maximum total CLTV and a maximum fees, this information will be actively used to prune edges when searching the graph for a route.