Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More options for fees - i.e "Cap at 20%" #36

Open
dpad85 opened this issue Apr 13, 2018 · 4 comments
Open

More options for fees - i.e "Cap at 20%" #36

dpad85 opened this issue Apr 13, 2018 · 4 comments

Comments

@dpad85
Copy link
Member

dpad85 commented Apr 13, 2018

Issue by CubicEarth
Friday Apr 06, 2018 at 15:15 GMT
Originally opened as ACINQ/eclair#548


The only option currently is to cap fees at 3%, or to not enforce at all.
I am sure that a more sophisticated approach will be developed in time, but until then, it would be good to have an option to allow fees to be up to some higher amount, while still caping them.

Is it possible that an uncapped fee could be more than 100%? For the next few months, people are going to be making many small 'test' payments to try out this new system. And fees are often higher than 3%. But an 'uncapped' fee seems like it opens up an attack vector.

So perhaps a second toggle button to allow fees up to 20%, or a simple slider to select a fee level?

@dpad85
Copy link
Member Author

dpad85 commented Apr 13, 2018

Comment by dpad85
Thursday Apr 12, 2018 at 18:47 GMT


Are you thinking about Eclair Wallet for this? For eclair node, this value can be changed by the user in eclair.conf and I don't think it need a specific UI widget.

For eclair wallet, however, it could certainly be useful.

@dpad85
Copy link
Member Author

dpad85 commented Apr 13, 2018

Comment by CubicEarth
Thursday Apr 12, 2018 at 22:39 GMT


@dpad85 - You are right, I meant that this issue be attached to the Eclair Wallet repo.

Is there a way to 'move' the issue over? Or should I just close it here, and repost it over there?

@irekzielinski
Copy link

Ideally - app would say something like:
"Found a path to pay an invoice but it requires high fee of: xxx sat which is YYY% of the the invoice value.
Do you want to proceed with the payment?"

I know that this introduces a race condition (user clicking OK, but fees changing) - but might be good enough.

@dpad85
Copy link
Member Author

dpad85 commented Feb 19, 2019

The fee protection mechanism has been improved with the v0.3.19 release (see #142 and ACINQ/eclair#844).

This is not as sophisticated as what @irekzielinski proposes though, so I let this issue open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants