Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jasmeen/improve comm res 831 #864

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Conversation

KAUR1984
Copy link
Contributor

@KAUR1984 KAUR1984 commented Jan 3, 2025

Fixes issue #831.

@KAUR1984 KAUR1984 added the ✏️ documentation Improvements or additions to documentation label Jan 3, 2025
@KAUR1984 KAUR1984 requested a review from a team January 3, 2025 00:18
@KAUR1984 KAUR1984 self-assigned this Jan 3, 2025
Copy link

github-actions bot commented Jan 3, 2025

PR preview
🛬 Preview link removed because the pull request was closed.

mkdocs.yml Show resolved Hide resolved
mkdocs.yml Show resolved Hide resolved
Copy link
Contributor

@heidinett heidinett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KAUR1984. Looks good!
In the PR preview, there appears to be a broken link when you click on the card "Model Evaluation links" under 'Community Resources' tab.
Is that because you plan to remove this card or do you plan to link to the new location of the model evaluation links?

@KAUR1984
Copy link
Contributor Author

KAUR1984 commented Jan 5, 2025

Thanks @KAUR1984. Looks good! In the PR preview, there appears to be a broken link when you click on the card "Model Evaluation links" under 'Community Resources' tab. Is that because you plan to remove this card or do you plan to link to the new location of the model evaluation links?

Thanks @heidinett ! Great point! Will remove this card from the home page, and update the PR as well :)

@KAUR1984 KAUR1984 requested a review from heidinett January 5, 2025 23:45
@KAUR1984 KAUR1984 merged commit 1cc5b51 into development Jan 6, 2025
10 of 11 checks passed
@KAUR1984 KAUR1984 deleted the jasmeen/improve-comm-res-831 branch January 6, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants