Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Ionosphere Phase Estimation #74

Merged
merged 21 commits into from
Jan 24, 2023
Merged

Adding Ionosphere Phase Estimation #74

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
adc8ab5
adding ionosphere for isce2 outputs
cmarshak Oct 20, 2022
96d1447
include example in readme
cmarshak Oct 20, 2022
0d4a705
include err i/o to sample
cmarshak Oct 21, 2022
6390d97
update geocoding
cmarshak Oct 21, 2022
4f39ecb
fix names in templates
cmarshak Oct 24, 2022
1b53849
include 2d layer additions with rioxarray
cmarshak Oct 25, 2022
d8d46c8
fix function call
cmarshak Oct 26, 2022
ff97663
finalize packaging
cmarshak Oct 26, 2022
4116d4d
lint
cmarshak Oct 26, 2022
87863ef
do-esd first pass
cmarshak Oct 26, 2022
3119d1a
fix underscore and type
cmarshak Oct 26, 2022
c0efbf5
use example from David Bekaert
cmarshak Nov 9, 2022
1b56dbd
add comments
cmarshak Nov 9, 2022
95c572a
fix trufflehog with jhk help
cmarshak Nov 9, 2022
499a927
add changelog
cmarshak Nov 10, 2022
710af66
revert packaging template
cmarshak Jan 17, 2023
bbba477
Merge branch 'dev' into ionosphere
cmarshak Jan 17, 2023
0b405a1
ensure default placeholders in packaging; consistency; Buzzanga H5 ov…
cmarshak Jan 17, 2023
f70553f
Merge branch 'ionosphere' of github.com:ACCESS-Cloud-Based-InSAR/Dock…
cmarshak Jan 17, 2023
57962c7
try micromamba
cmarshak Jan 18, 2023
b98ecd1
update mask and 1km reprojection
cmarshak Jan 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ This example shows how to obtain a layer with ionsopheric phase delay. The SLCs
```
isce2_topsapp --reference-scenes S1A_IW_SLC__1SDV_20221002T151520_20221002T151543_045265_056931_E517 \
--secondary-scenes S1A_IW_SLC__1SDV_20220908T151520_20220908T151542_044915_055D68_78EC \
--estimate-ionosphere-delay True
--estimate-ionosphere-delay True \
> topsapp_img.out 2> topsapp_img.err
```

# Running with Docker (locally or on a server)
Expand Down
2 changes: 1 addition & 1 deletion isce2_topsapp/templates/topsapp_template.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@
<property name="do ESD">{{ do_esd }}</property>
<property name="ESD coherence threshold">{{ esd_coherence_threshold }}</property>
<property name="use virtual files">{{ use_virtual_files }}</property>
<property name="geocode list">['merged/phsig.cor', 'merged/filt_topophase.unw', 'merged/los.rdr', 'merged/topophase.flat', 'merged/filt_topophase.flat', 'merged/filt_topophase_2stage.unw', 'merged/topophase.cor', 'merged/filt_topophase.unw.conncomp']</property>
<property name="geocode list">{{ geocode_list }}</property>
</component>
</topsApp>
16 changes: 15 additions & 1 deletion isce2_topsapp/topsapp_proc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,15 @@

TEMPLATE_DIR = Path(__file__).parent/'templates'

GEOCODE_LIST_BASE = ['merged/phsig.cor',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check if we use all of these? I would only geocode the ones that gets used in the product. which would be fitlered coherence and filtered unwrapped phase corrected for DEM and topophase.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are taken from here: https://github.com/aria-jpl/ariamh/blob/develop/interferogram/sentinel/topsApp.xml.tmpl#L32

'merged/filt_topophase.unw',
'merged/los.rdr',
'merged/topophase.flat',
'merged/filt_topophase.flat',
'merged/filt_topophase_2stage.unw',
'merged/topophase.cor',
'merged/filt_topophase.unw.conncomp']


def topsapp_processing(*,
reference_slc_zips: list,
Expand All @@ -50,6 +59,10 @@ def topsapp_processing(*,
with open(TEMPLATE_DIR/'topsapp_template.xml', 'r') as file:
template = Template(file.read())

geocode_list = GEOCODE_LIST_BASE.copy()
if estimate_ionosphere_delay:
geocode_list.append('merged/topophase.ion')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmarshak just to double check if this is the unwrapped topophase or the wrapped variant.
Check if tehre is not a topophase.ion.unw or so

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's look at the products together. I was going to just include this raster in the product.


topsApp_xml = template.render(orbit_directory=orbit_directory,
output_reference_directory='reference',
output_secondary_directory='secondary',
Expand All @@ -66,7 +79,8 @@ def topsapp_processing(*,
estimate_ionosphere_delay=estimate_ionosphere_delay,
azimuth_looks=azimuth_looks,
range_looks=range_looks,
swaths=swaths
swaths=swaths,
geocode_list=geocode_list
)
with open('topsApp.xml', "w") as file:
file.write(topsApp_xml)
Expand Down