-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Ionosphere Phase Estimation #74
Conversation
@@ -50,6 +59,10 @@ def topsapp_processing(*, | |||
with open(TEMPLATE_DIR/'topsapp_template.xml', 'r') as file: | |||
template = Template(file.read()) | |||
|
|||
geocode_list = GEOCODE_LIST_BASE.copy() | |||
if estimate_ionosphere_delay: | |||
geocode_list.append('merged/topophase.ion') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cmarshak just to double check if this is the unwrapped topophase or the wrapped variant.
Check if tehre is not a topophase.ion.unw or so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's look at the products together. I was going to just include this raster in the product.
@@ -25,6 +25,15 @@ | |||
|
|||
TEMPLATE_DIR = Path(__file__).parent/'templates' | |||
|
|||
GEOCODE_LIST_BASE = ['merged/phsig.cor', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should check if we use all of these? I would only geocode the ones that gets used in the product. which would be fitlered coherence and filtered unwrapped phase corrected for DEM and topophase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are taken from here: https://github.com/aria-jpl/ariamh/blob/develop/interferogram/sentinel/topsApp.xml.tmpl#L32
Going to update example based on continued scalloping of the example initially given. More discussion is given here (by the insar experts): isce-framework/isce2#620 Here is new example given by @dbekaert:
|
Using the SLCs that David recommended, I am attaching the browse image and the link to the resulting gunw. Notes:
For futher discussion:
|
Some things to check:
Note that for tropo and offsets we will need to do this work still in ARIA-tools and we will also need to correct for the internal version. It could however be the same one as we have not used it beyond prototyping.
In terms of future discussion item: to clarify
|
@ehavazli Can you have a look into this as well? |
I would recommend not running the range split-spectrum ionospheric estimation and the ESD calculation on the same product as they both estimate azimuth shifts and will likely have a strong trade-off. |
…erizedTopsApp into ionosphere
Unfortunately, I want things to break more and to not be a blocker for a lot of parallel development. I am going to merge and include additional tests in the future. |
Provides API functionality (through the associated CLI of the plugin) for:
Both of which are included in ISCE2 and requires modification of the
topsApp.xml
file (look at the example xml for all the features that can be included). Here is our template for this PR.This pull request also packages the ionosphere layer within the GUWN product. Specifically, takes
merged/topophase.ion.geo
and puts into the netcdf group/science/grids/corrections/derived/ionosphere
.The ESD outputs are not preserved currently. This is because I am not aware how.
The current test for the PR is the following:
The above test is included in the readme.
Additional notes:
xarray
(andrioxarray
). It is much cleaner than writing netcdf attributes and coordinates directly. However, because there is a placeholder for/science/grids/corrections/derived/ionosphere
typed as a string in the existing packaging template and workflow, I simply removed this from the packaging template json here. Reproducing the json excerpt below for posterity as the link is to the dev branch, which will presumably be updated if/when this PR is merged. There might be better ways of overwriting variables withinxarray
(specifically overwriting their type), but haven't looked into it. As a result, if ionosphere is turned off, the layer will be deleted (no placeholder).