Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lung 2 scaffold #200

Merged
merged 22 commits into from
Jul 6, 2022
Merged

Lung 2 scaffold #200

merged 22 commits into from
Jul 6, 2022

Conversation

rchristie
Copy link
Member

No description provided.

Copy link
Member

@mahyar-osn mahyar-osn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked and tested. Look great!

Refactor with reusable utility functions. Simplify code and remove hand-edited derivatives.
Fix general test for more accurate brainstem coordinates.
Fix definition of ellipsoid u, v coordinates to give outward normal from cross product of first and second derivatives.
Change collapse direction of triangle element in lower lobe.
Update test answers.
Copy link
Member

@mahyar-osn mahyar-osn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked and tested on my machine. Looks great!

@rchristie rchristie merged commit ba50d90 into ABI-Software:main Jul 6, 2022
@rchristie rchristie deleted the lung2_grc branch July 6, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants