Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a generic lung scaffold and its parameters for species #196

Closed
wants to merge 11 commits into from
Closed

Create a generic lung scaffold and its parameters for species #196

wants to merge 11 commits into from

Conversation

arti-sukasem
Copy link
Contributor

I created a new pull request to clean up my commit history #194. I fixed all the requests and updated parameters in species.

rchristie
rchristie approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@rchristie rchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to get into main branch, but we will make some fixes to it with a subsequent pull request.

@rchristie
Copy link
Member

Closing as moved (with revisions to fix conflicts) to #200.

@rchristie rchristie closed this Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchristie rchristie rchristie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arti-sukasem @rchristie