Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert creates tempdir in parent of destination #99

Merged
merged 2 commits into from
Nov 18, 2024

Commits on Oct 28, 2024

  1. Convert creates tempdir in parent of destination

    `git prole convert` now creates a tempdir in the parent of the
    determined destination of the converted repo.
    This prevents some errors when the /tmp directory is on a different
    filesystem, such as a tmpfs.
    
    The tempdir will be deleted if and only if it is empty after conversion.
    This should always be the case and is to prevent any data loss.
    
    Fixes issue 9999years#96
    lordkekz committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    35b6cc7 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Fix read_dir logic error, improve error messages

    * `fs::read_dir` skips entries for the current and parent directories, so
      we want it to be completely empty to delete the temporary directory.
    
    * Add a local `fs::read_dir` wrapper for `fs_err::read_dir` to match the
      others in that module.
    
    * Show a warning, not an info message, if the tempdir isn't empty.
    
    * Include the paths in the tempdir in the warning message.
    9999years committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    e76e393 View commit details
    Browse the repository at this point in the history