Convert creates tempdir in parent of destination #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`git prole convert` now creates a tempdir in the parent of the determined destination of the converted repo. This prevents some errors when the /tmp directory is on a different filesystem, such as a tmpfs. The tempdir will be deleted if and only if it is empty after conversion. This should always be the case and is to prevent any data loss. Fixes issue 9999years#96
|
Thanks for the contribution! |
* `fs::read_dir` skips entries for the current and parent directories, so we want it to be completely empty to delete the temporary directory. * Add a local `fs::read_dir` wrapper for `fs_err::read_dir` to match the others in that module. * Show a warning, not an info message, if the tempdir isn't empty. * Include the paths in the tempdir in the warning message.
|
Looks good! I improved the error message a bit and added some wrappers to match the rest of the codebase, so I'll merge it after tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #96
I tested the change on some repos (no longer gives the error) and ran the tests with
nix flake check.Please do review this carefully since I'm still pretty new to Rust. ^^
Change summary
git prole convertnow creates a tempdir in the parent of the determined destination of the converted repo.This prevents some errors when the /tmp directory is on a different filesystem, such as a tmpfs.
The tempdir will be deleted if and only if it is empty after conversion. This should always be the case and is to prevent any data loss.