Added same imgur and stuff album downloaders characteristics to ChanRipper #185
Conversation
|
This one need some cleaning up before you can merge it, doesn't it? |
|
I like this change; but there's conflicts so I can't auto-merge. |
|
@EraYaN could you clean this up and resolve conflicts in this PR so I can merge it? |
|
Mmm, I'll need to review and rebase, I think. I can do it somewhere this week. Otherwise over the Christmas break. |
|
@EraYaN Thanks! I'd really appreciate it. I'll be checking in frequently. |
EraYaN
force-pushed
the
feature-betterchanripper-bestpractices
branch
from
0b444ee to
f846e36
Compare
|
I rebased onto master. |
|
@EraYaN Thanks! |
|
It compiled in January. Let me have a look. |
| import com.rarchives.ripme.utils.Utils; | ||
| >>>>>>> Added same imgur and stuff album downloaders characteristics to ChanRipper. | ||
| ======= | ||
| >>>>>>> Added isEmpty to History, fixed some best practices in the code. |
|
|
||
| ======= | ||
|
|
||
| >>>>>>> Added isEmpty to History, fixed some best practices in the code. |
| public void windowDeiconified(WindowEvent e) { trayMenuMain.setLabel("Hide"); } | ||
| @Override |
There was a problem hiding this comment.
Maybe put these on the same line as the definition to keep the one-line method consistent?
There was a problem hiding this comment.
This is not my code. But in the same style as C style pragma this should probably be above the method.
EDIT: In other spots in the code it is also done as a method decorator (above the method declaration, with the same indent)
There was a problem hiding this comment.
I have no strong opinion on this. Function over style, IMO. It's fiine as-is.
| //TODO implement proper stack trace handling this is really just intented as a placeholder until you implement proper error handling | ||
| e.printStackTrace(); | ||
| } catch (AWTException e) { | ||
| //TODO implement proper stack trace handling this is really just intented as a placeholder until you implement proper error handling |
There was a problem hiding this comment.
Yeah, that's true, but I think this code pattern is fair though. The point is to catch the exception, print it out so that someone can investigate it from the log, and not actually crash the program. (It is possible to continue the program and just not finish the operation that excepted.)
|
I promise I'll actually test and give feedback as soon as you update this time, rather than letting it sit around forever. |
|
Well I think it's ready again. Unless you want me to remove the //TODO comments. |
|
(Apparently as soon as I can is two weeks...) |
So now the chanripper also rips imgur albums.
The building error is in the instagram ripper. "SocketTimedOut" doesn't seem to be a code issue.
I tried to make the UI more flexible (proper resizing) but ugh I hate java UI's, I'm too used to the ease of use of WPF. So it wouldn't work.