Video Ripper Broken

[rephormat]

No longer able to download videos. Sample error log from xHamster is attached.

Affected versions: >= 1.4.14

ripme.txt

[cyian-1756]

Can you give an example link?

Edit: nevermind it's in the log https://xhamster.com/movies/7711362/mature_take_a_shower.html

[cyian-1756]

After a bit of looking it seems that one of the updates since 1.4.13 has broken the ripper, I'll diff the versions and see if I can fix it

[cyian-1756]

It looks like it was some of the changes @metaprime made here that broke the video ripper.

Replacing that file with the version from 1.4.13 fixes the error

[rephormat]

Confirmed @cyian-1756 findings. The video ripper is broken for all supported sites. Updating Issue.

[metaprime]

@cyian-1756 which file did you replace to fix it?

[metaprime]

Oh it's this change (part of #185):

-            } catch (Exception e) {
+            } catch (InstantiationException e) {
+                // Incompatible rippers *will* throw exceptions during instantiation.
+            } catch (IllegalAccessException e) {
+                // Incompatible rippers *will* throw exceptions during instantiation.
+            } catch (IllegalArgumentException e) {
+                // Incompatible rippers *will* throw exceptions during instantiation.
+            } catch (InvocationTargetException e) {
                 // Incompatible rippers *will* throw exceptions during instantiation.
             }

I wasn't a fan of this to begin with (but no strong opinion so I merged it anyway). There's no value in enumerating each type of exception when the handling is the same. And look, it introduced a bug by not handling all cases.

This also points out the need for improving test coverage and fixing up the CI...

[metaprime]

Fixed in 1.4.18