Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add StandAloneClusterSDK #501

Merged
merged 11 commits into from
Oct 14, 2021
Merged

Conversation

vagetablechicken
Copy link
Collaborator

@vagetablechicken vagetablechicken commented Oct 9, 2021

Closes #441

base class ClusterSDK, NormalClusterSDK use zk to get meta data, StandAloneClusterSDK use host&port config to connect nameserver directly.

If start openmldb with no role, we'll parse --host --port which is ns address.

StandAloneClusterSDK can't get sp infos now, it'll be fixed in the next pr.

@vagetablechicken vagetablechicken changed the title feat: support connecting ns with host and port feat: add StandAloneClusterSDK Oct 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2021

Linux Test Report

     55 files     130 suites   34m 48s ⏱️
8 060 tests 8 060 ✔️ 0 💤 0
8 065 runs  8 065 ✔️ 0 💤 0

Results for commit 5935d26.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Oct 9, 2021

Codecov Report

Merging #501 (38ac7a7) into main (608f268) will not change coverage.
The diff coverage is n/a.

❗ Current head 38ac7a7 differs from pull request most recent head 5935d26. Consider uploading reports for the commit 5935d26 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##               main     #501   +/-   ##
=========================================
  Coverage     82.27%   82.27%           
  Complexity       17       17           
=========================================
  Files           283      283           
  Lines         50894    50894           
  Branches         30       30           
=========================================
  Hits          41874    41874           
  Misses         9011     9011           
  Partials          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 608f268...5935d26. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2021

HybridSE Linux Test Report

       71 files       228 suites   5m 24s ⏱️
18 343 tests 18 343 ✔️ 0 💤 0
18 360 runs  18 360 ✔️ 0 💤 0

Results for commit 5935d26.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2021

HybridSE Mac Test Report

       71 files       228 suites   5m 33s ⏱️
18 343 tests 18 343 ✔️ 0 💤 0
18 360 runs  18 360 ✔️ 0 💤 0

Results for commit 5935d26.

♻️ This comment has been updated with latest results.

src/cmd/sql_cmd.h Outdated Show resolved Hide resolved
src/cmd/sql_cmd.h Outdated Show resolved Hide resolved
src/sdk/cluster_sdk.h Outdated Show resolved Hide resolved
src/sdk/cluster_sdk.h Outdated Show resolved Hide resolved
@dl239 dl239 merged commit fd6d117 into 4paradigm:main Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use nameserver ip and port to connect openmldb
3 participants