Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: GetNsClient can't get the new client if ns changed #515

Closed
vagetablechicken opened this issue Oct 13, 2021 · 3 comments · Fixed by #1963
Closed

bug: GetNsClient can't get the new client if ns changed #515

vagetablechicken opened this issue Oct 13, 2021 · 3 comments · Fixed by #1963
Assignees
@vagetablechicken
Labels
bug Something isn't working call-for-contributions high-priority

Comments

@vagetablechicken
Copy link
Collaborator

vagetablechicken commented Oct 13, 2021 •
edited
Loading

ns_client_ won't be deleted, so it can't be recreated when ns changed. Let's add a todo, fix it in the next time.

Originally posted by @vagetablechicken in #501 (comment)
@dl239 dl239 added the bug Something isn't working label Oct 14, 2021
@dl239
Copy link
Collaborator

dl239 commented May 5, 2022

  • add watch to ns leader node
  • update ns_client if nameserver leader changed.

@dl239
Copy link
Collaborator

dl239 commented Jun 7, 2022

High-priority Bugs (0.5.x)

@vagetablechicken
Copy link
Collaborator Author

taskmanager client can't refresh, so add a watch for it too.

@vagetablechicken vagetablechicken mentioned this issue Jun 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vagetablechicken vagetablechicken

Labels
bug Something isn't working call-for-contributions high-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update ns&taskmanager client when zk changed vagetablechicken/fedb
3 participants
@lumianph @dl239 @vagetablechicken