Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update ns&taskmanager client when zk changed #1963

Merged
merged 2 commits into from
Jun 17, 2022

Conversation

vagetablechicken
Copy link
Collaborator

Closes #515

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jun 14, 2022
@github-actions
Copy link
Contributor

SDK Test Report

  75 files    75 suites   6m 19s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit 1b25ac1.

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #1963 (1b25ac1) into main (7717523) will increase coverage by 0.00%.
The diff coverage is 81.81%.

@@            Coverage Diff            @@
##               main    #1963   +/-   ##
=========================================
  Coverage     75.62%   75.63%           
  Complexity      347      347           
=========================================
  Files           614      614           
  Lines        116975   116983    +8     
  Branches       1022     1022           
=========================================
+ Hits          88464    88477   +13     
+ Misses        28302    28297    -5     
  Partials        209      209           
Impacted Files Coverage Δ
src/sdk/db_sdk.h 92.50% <ø> (ø)
src/sdk/db_sdk.cc 67.64% <76.47%> (+3.79%) ⬆️
src/zk/dist_lock.cc 81.81% <100.00%> (-1.52%) ⬇️
src/catalog/tablet_catalog.cc 73.77% <0.00%> (-0.87%) ⬇️
src/client/tablet_client.cc 55.19% <0.00%> (-0.12%) ⬇️
src/tablet/tablet_impl.cc 59.42% <0.00%> (-0.10%) ⬇️
src/nameserver/name_server_impl.cc 42.78% <0.00%> (-0.03%) ⬇️
src/zk/zk_client.cc 83.37% <0.00%> (+0.25%) ⬆️
hybridse/src/udf/udf_library.cc 81.35% <0.00%> (+0.42%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7717523...1b25ac1. Read the comment docs.

@github-actions
Copy link
Contributor

Linux Test Report

       57 files       196 suites   49m 17s ⏱️
  8 941 tests   8 937 ✔️ 4 💤 0
13 157 runs  13 153 ✔️ 4 💤 0

Results for commit 1b25ac1.

@vagetablechicken vagetablechicken merged commit ab8f2bb into 4paradigm:main Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: GetNsClient can't get the new client if ns changed
3 participants