-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: coverage #3774
fix: coverage #3774
Conversation
Linux Test Report 57 files + 57 244 suites +244 1h 16m 45s ⏱️ + 1h 16m 45s Results for commit 42b74c5. ± Comparison against base commit 47a61cb. ♻️ This comment has been updated with latest results. |
SDK Test Report101 files ±0 101 suites ±0 2m 6s ⏱️ +4s Results for commit 42b74c5. ± Comparison against base commit 47a61cb. This pull request removes 30 and adds 9 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3774 +/- ##
=============================================
+ Coverage 40.26% 74.88% +34.61%
Complexity 658 658
=============================================
Files 194 737 +543
Lines 11426 132521 +121095
Branches 1378 1378
=============================================
+ Hits 4601 99240 +94639
- Misses 6521 32977 +26456
Partials 304 304 ☔ View full report in Codecov by Sentry. |
That should the common issue when linking a shared library against static libraray, see https://stackoverflow.com/questions/23696585/what-does-exactly-the-warning-mean-about-hidden-symbol-being-referenced-by-dso So I've try bundle source code of glog (plug gflags and anything necessary), then we can link at least gflag & glog from source |
it build glog_shared, and FindPackage(glog) will find shared library first ? |
It seems so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
When
glog
compiles a static library, it will hide some symbols in v0.6.0 (refer here) so that coverage cannot find the symbols in linking stage when it relies on the dynamic librariesA quick temporary solution is to compile the glog dynamic library before running coverage