build: support build glog/gflags from source #3778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- link glog staticlly or dynamicly. - deps issue for libunwind, no lzma dependency. - glog dependency to libunwind
github-actions
bot
added
workflow
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3778 +/- ##
============================================
+ Coverage 74.88% 74.91% +0.03%
Complexity 658 658
============================================
Files 737 737
Lines 132521 132541 +20
Branches 1378 1380 +2
============================================
+ Hits 99240 99295 +55
+ Misses 32977 32942 -35
Partials 304 304 ☔ View full report in Codecov by Sentry. |
HybridSE Mac Test Report20 094 tests 20 092 ✅ 10m 44s ⏱️ Results for commit 716d585. ♻️ This comment has been updated with latest results. |
HybridSE Linux Test Report20 094 tests 20 092 ✅ 6m 21s ⏱️ Results for commit 716d585. ♻️ This comment has been updated with latest results. |
aceforeverd
force-pushed
the
build-glog-gflags-from-source
branch
from
e4572f6
to
716d585
Compare
dl239
approved these changes
Mar 1, 2024
|
TODO: recheck #3407 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
long term fix for dynamic linking issue in #3774
fix #1932
and possibly #3407, but need extra check
rewrite from #3439