feat: built-in function: Support hex() function #819 #2159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HGZ-20
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2159 +/- ##
============================================
+ Coverage 75.75% 75.78% +0.02%
- Complexity 353 354 +1
============================================
Files 619 619
Lines 117301 117523 +222
Branches 1039 1039
============================================
+ Hits 88864 89066 +202
- Misses 28226 28246 +20
Partials 211 211
Continue to review full report at Codecov.
|
aceforeverd
reviewed
Jul 13, 2022
aceforeverd
reviewed
Jul 14, 2022
aceforeverd
reviewed
Jul 14, 2022
hybridse/src/udf/udf.h
Outdated
| if (std::is_same<V, float>::value || std::is_same<V, double>::value) { | ||
| double numbuf = std::round(v); | ||
| if (numbuf < LLONG_MIN) ss << std::hex << std::uppercase << int64_t(LLONG_MIN); | ||
| else if (numbuf > LLONG_MAX) ss << std::hex << std::uppercase << int64_t(LLONG_MAX); |
There was a problem hiding this comment.
does it really overflow ?
|
merge after #2175 , it fix seg fault error here |
aceforeverd
approved these changes
Jul 21, 2022
|
@zhanghaohit calling reviewer |
zhanghaohit
approved these changes
Jul 22, 2022
|
Thanks @HGZ-20 for the contribution. It is now merged. |
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
built-in function: Support
hex()function #819What is the new behavior (if this is a feature change)?
built-in function: Support hex() function