Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(#2168): reimpl dayofyear udf #2175

Merged

Conversation

aceforeverd
Copy link
Collaborator

  • fix returns null value
  • teach gtest print readable Nullable variable

#2168 related but not fully resolved by this PR

- fix returns `null` value
- teach gtest print readable `Nullable` variable
@github-actions github-actions bot added the execute-engine hybridse sql engine label Jul 14, 2022
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #2175 (941b165) into main (467e231) will increase coverage by 38.67%.
The diff coverage is 77.58%.

@@              Coverage Diff              @@
##               main    #2175       +/-   ##
=============================================
+ Coverage     37.09%   75.76%   +38.67%     
  Complexity      353      353               
=============================================
  Files           143      619      +476     
  Lines          8557   117253   +108696     
  Branches       1039     1039               
=============================================
+ Hits           3174    88835    +85661     
- Misses         5172    28207    +23035     
  Partials        211      211               
Impacted Files Coverage Δ
hybridse/src/udf/literal_traits.h 93.82% <0.00%> (ø)
hybridse/src/udf/udf.h 100.00% <ø> (ø)
include/base/type.h 85.48% <0.00%> (ø)
hybridse/src/udf/udf.cc 85.24% <90.00%> (ø)
hybridse/src/codegen/udf_ir_builder_test.cc 99.48% <100.00%> (ø)
hybridse/src/udf/default_udf_library.cc 96.86% <100.00%> (ø)
src/log/log_test.cc 99.01% <0.00%> (ø)
src/sdk/mini_cluster.h 78.88% <0.00%> (ø)
hybridse/src/codegen/cond_select_ir_builder.cc 100.00% <0.00%> (ø)
hybridse/include/base/iterator.h 100.00% <0.00%> (ø)
... and 472 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 467e231...941b165. Read the comment docs.

@github-actions
Copy link
Contributor

HybridSE Linux Test Report

19 278 tests   19 276 ✔️  5m 30s ⏱️
     237 suites           2 💤
       67 files             0

Results for commit 941b165.

@github-actions
Copy link
Contributor

HybridSE Mac Test Report

19 278 tests   19 276 ✔️  7m 5s ⏱️
     237 suites           2 💤
       67 files             0

Results for commit 941b165.

@github-actions
Copy link
Contributor

SDK Test Report

  77 files    77 suites   8m 23s ⏱️
165 tests 163 ✔️ 2 💤 0
206 runs  204 ✔️ 2 💤 0

Results for commit 941b165.

@github-actions
Copy link
Contributor

Linux Test Report

       55 files       200 suites   51m 20s ⏱️
  9 227 tests   9 223 ✔️ 4 💤 0
13 578 runs  13 574 ✔️ 4 💤 0

Results for commit 941b165.

@zhanghaohit zhanghaohit merged commit be78fe7 into 4paradigm:main Jul 18, 2022
DDreame added a commit to DDreame/OpenMLDB that referenced this pull request Jul 18, 2022
@aceforeverd aceforeverd deleted the refactor-udfs-dayofyear-2168 branch July 18, 2022 02:04
@lumianph
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-engine hybridse sql engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants