-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(#2168): reimpl dayofyear
udf
#2175
Merged
zhanghaohit
merged 1 commit into
4paradigm:main
from
aceforeverd:refactor-udfs-dayofyear-2168
Jul 18, 2022
Merged
refactor(#2168): reimpl dayofyear
udf
#2175
zhanghaohit
merged 1 commit into
4paradigm:main
from
aceforeverd:refactor-udfs-dayofyear-2168
Jul 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2175 +/- ##
=============================================
+ Coverage 37.09% 75.76% +38.67%
Complexity 353 353
=============================================
Files 143 619 +476
Lines 8557 117253 +108696
Branches 1039 1039
=============================================
+ Hits 3174 88835 +85661
- Misses 5172 28207 +23035
Partials 211 211
Continue to review full report at Codecov.
|
dl239
approved these changes
Jul 15, 2022
zhanghaohit
approved these changes
Jul 18, 2022
DDreame
added a commit
to DDreame/OpenMLDB
that referenced
this pull request
Jul 18, 2022
refactor(4paradigm#2168): reimpl `dayofyear` udf (4paradigm#2175)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null
valueNullable
variable#2168 related but not fully resolved by this PR