fix: delete unused images from images dir #2083
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KikiDotPy
changed the title
KikiDotPy
changed the title
KikiDotPy
changed the title
KikiDotPy
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2083 +/- ##
============================================
- Coverage 75.72% 75.71% -0.02%
Complexity 347 347
============================================
Files 615 615
Lines 116901 116901
Branches 1015 1015
============================================
- Hits 88523 88507 -16
- Misses 28169 28185 +16
Partials 209 209
Continue to review full report at Codecov.
|
github-actions
bot
added
the
storage-engine
dl239
reviewed
Jul 6, 2022
| @@ -43,10 +43,10 @@ void OnLockedCallback() { call_invoked = true; } | |||
| void OnLostCallback() {} | |||
|
|
|||
| TEST_F(DistLockTest, Lock) { | |||
| ZkClient client("127.0.0.1:6181", "", 10000, "127.0.0.1:9527", "/rtidb_lock"); | |||
| ZkClient client("127.0.0.1:6181", "", 10000, "127.0.0.1:9527", "/openmldb_lock"); | |||
There was a problem hiding this comment.
hi @KikiDotPy , please revert zk/dist_lock_test.cc and zk/zk_client_test.cc. This task has been done in #2086
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleted images requested in issues #2082
images/fedb_arch.png
images/fedb_black.png
images/openmldb_architecture.jpg
images/openmldb_architecture.png