Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: renamed from rtidb to openmldb in dist_lock_test.cc and zk_client_tes… #2086

Merged
merged 2 commits into from
Jul 6, 2022
Merged

Conversation

marc-marcos
Copy link
Contributor

…t.css

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Update

Solving issue: #2081

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jul 5, 2022
@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #2086 (2dad0ab) into main (a8f8c91) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2086      +/-   ##
============================================
+ Coverage     75.72%   75.78%   +0.05%     
  Complexity      347      347              
============================================
  Files           615      615              
  Lines        116901   116921      +20     
  Branches       1015     1015              
============================================
+ Hits          88523    88607      +84     
+ Misses        28169    28105      -64     
  Partials        209      209              
Impacted Files Coverage Δ
src/zk/dist_lock_test.cc 86.11% <100.00%> (ø)
src/zk/zk_client_test.cc 100.00% <100.00%> (ø)
src/log/status.h 70.83% <0.00%> (-12.50%) ⬇️
src/replica/replicate_node.cc 74.30% <0.00%> (-3.92%) ⬇️
src/sdk/db_sdk.cc 63.45% <0.00%> (-3.14%) ⬇️
src/log/log_reader.cc 76.47% <0.00%> (-2.65%) ⬇️
src/zk/dist_lock.cc 81.81% <0.00%> (-1.52%) ⬇️
hybridse/src/codec/fe_row_codec.cc 78.33% <0.00%> (-0.32%) ⬇️
src/nameserver/name_server_impl.cc 42.78% <0.00%> (-0.05%) ⬇️
hybridse/src/vm/runner.cc 67.73% <0.00%> (-0.04%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8f8c91...2dad0ab. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

Linux Test Report

       54 files       196 suites   54m 20s ⏱️
  9 009 tests   9 005 ✔️ 4 💤 0
13 260 runs  13 256 ✔️ 4 💤 0

Results for commit 2dad0ab.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

SDK Test Report

  75 files    75 suites   7m 13s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit 2dad0ab.

♻️ This comment has been updated with latest results.

src/zk/dist_lock_test.cc Outdated Show resolved Hide resolved
@dl239 dl239 changed the title Renamed from rtidb to openmldb in dist_lock_test.cc and zk_client_tes… refactor: renamed from rtidb to openmldb in dist_lock_test.cc and zk_client_tes… Jul 6, 2022
@dl239 dl239 linked an issue Jul 6, 2022 that may be closed by this pull request
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dl239 dl239 merged commit f216da4 into 4paradigm:main Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename rtidb to openmldb in some files
3 participants