Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo method name from DataHandler abstract method #1874

Closed
aceforeverd opened this issue May 24, 2022 · 2 comments · Fixed by #1878
Closed

typo method name from DataHandler abstract method #1874

aceforeverd opened this issue May 24, 2022 · 2 comments · Fixed by #1878
Assignees
@aceforeverd
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@aceforeverd
Copy link
Collaborator

aceforeverd commented May 24, 2022 •
edited
Loading

OpenMLDB/hybridse/include/vm/catalog.h

Line 89 in 6f993f3

virtual const HandlerType GetHanlderType() = 0;

should be GetHandlerType.

To fix this, you need change the method name for both abstract class and inherit classes, like:

then update callee names elsewhere as well
@aceforeverd aceforeverd added the enhancement New feature or request label May 24, 2022
@aceforeverd aceforeverd self-assigned this May 24, 2022
@lumianph
Copy link
Collaborator

can set this as good first issue?

@lumianph lumianph added the good first issue Good for newcomers label May 25, 2022
@aceforeverd
Copy link
Collaborator Author

can set this as good first issue?

Can be, but need a bit more guide

@aceforeverd aceforeverd changed the title typo name from DataHandler abstract method typo method name from DataHandler abstract method May 25, 2022
@PrajwalBorkar PrajwalBorkar mentioned this issue May 25, 2022
Merged
vagetablechicken pushed a commit that referenced this issue May 26, 2022
@PrajwalBorkar
style(#1874): resolve typo function name for data handler (#1878)
3bf78ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aceforeverd aceforeverd

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

style(#1874): resolve typo function name for data handler
2 participants
@lumianph @aceforeverd