Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(#1874): resolve typo function name for data handler #1878

Merged
merged 5 commits into from
May 26, 2022
Merged

style(#1874): resolve typo function name for data handler #1878

merged 5 commits into from
May 26, 2022

Conversation

PrajwalBorkar
Copy link
Contributor

@github-actions github-actions bot added the execute-engine hybridse sql engine label May 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2022

Linux Test Report

       57 files       187 suites   1h 4m 42s ⏱️
  8 503 tests   8 499 ✔️ 4 💤 0
12 489 runs  12 485 ✔️ 4 💤 0

Results for commit 4e71f3c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2022

SDK Test Report

  75 files    75 suites   7m 32s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit 4e71f3c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2022

HybridSE Linux Test Report

       67 files       235 suites   5m 15s ⏱️
19 059 tests 19 057 ✔️ 2 💤 0

Results for commit 4e71f3c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2022

HybridSE Mac Test Report

       67 files       235 suites   6m 57s ⏱️
19 059 tests 19 057 ✔️ 2 💤 0

Results for commit 4e71f3c.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #1878 (4e71f3c) into main (f836165) will increase coverage by 0.00%.
The diff coverage is 88.88%.

@@            Coverage Diff            @@
##               main    #1878   +/-   ##
=========================================
  Coverage     75.70%   75.70%           
  Complexity      347      347           
=========================================
  Files           613      613           
  Lines        117031   117018   -13     
  Branches       1024     1024           
=========================================
- Hits          88597    88591    -6     
+ Misses        28225    28218    -7     
  Partials        209      209           
Impacted Files Coverage Δ
hybridse/src/vm/catalog_wrapper.h 45.25% <50.00%> (ø)
hybridse/src/vm/runner.cc 67.80% <90.00%> (+0.03%) ⬆️
hybridse/include/vm/catalog.h 46.77% <100.00%> (ø)
hybridse/src/vm/engine.cc 77.02% <100.00%> (ø)
src/rpc/rpc_client.h 89.18% <0.00%> (-1.36%) ⬇️
src/sdk/db_sdk.cc 62.58% <0.00%> (-0.46%) ⬇️
src/sdk/sql_cluster_router.cc 54.84% <0.00%> (-0.13%) ⬇️
src/tablet/tablet_impl.cc 59.44% <0.00%> (-0.05%) ⬇️
hybridse/src/codec/fe_row_codec.cc 78.96% <0.00%> (+0.15%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f836165...4e71f3c. Read the comment docs.

@aceforeverd aceforeverd changed the title Fixed Typo style(#1874): resolve typo function name for data handler May 26, 2022
@aceforeverd aceforeverd self-requested a review May 26, 2022 00:42
@aceforeverd aceforeverd requested review from zhanghaohit and dl239 May 26, 2022 00:43
@aceforeverd aceforeverd added the good first issue Good for newcomers label May 26, 2022
@aceforeverd aceforeverd added this to the v0.6 milestone May 26, 2022
Copy link
Collaborator

@zhanghaohit zhanghaohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vagetablechicken vagetablechicken merged commit 3bf78ae into 4paradigm:main May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-engine hybridse sql engine good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typo method name from DataHandler abstract method
5 participants