-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
640 방 나가기 api #677
Merged
The head ref may contain hidden characters: "640-\uBC29-\uB098\uAC00\uAE30-API"
Merged
640 방 나가기 api #677
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f501b88
[FEAT] 방나가기 api
ghyen 3745fc8
[FEAT] 방나가기 api
ghyen 50d0e9a
Merge branch 'dev' into 640-방-나가기-API
ghyen 7892a61
[FIX] After merge modified
ghyen 7d4e086
[FIX] checkstyle at utils.TestDataUtils "import gg.auth.utils.AuthTok…
ghyen fc29d03
[FIX] checkstyle fix
ghyen 4220bf5
[FIX] checkstyle fix
ghyen edb9f59
[FIX] fixed service naming convention and api endpoint and RoomType val
ghyen 37970df
[FIX] fixed controller naming convention
ghyen 19d0619
[FIX] 방 나가기 관련 에러 수정, 리뷰 내용 수정 (#640)
yes-ee 814c287
Merge branch '640-방-나가기-API' of https://github.com/42organization/42g…
yes-ee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,36 @@ | ||
package gg.data.party.type; | ||
|
||
import java.util.Locale; | ||
|
||
import com.fasterxml.jackson.annotation.JsonCreator; | ||
|
||
import lombok.Getter; | ||
import lombok.RequiredArgsConstructor; | ||
|
||
@Getter | ||
@RequiredArgsConstructor | ||
public enum RoomType { | ||
OPEN, // Ordinal 0 | ||
START, // Ordinal 1 | ||
FINISH, // Ordinal 2 | ||
HIDDEN // Ordinal 3 | ||
OPEN("open", "방 시작 전"), | ||
START("live", "방 진행 중"), | ||
FINISH("end", "방 종료"), | ||
HIDDEN("end", "신고로 인한 가림 상태"), | ||
FAIL("end", "매칭 실패한 방"); | ||
|
||
private final String code; | ||
private final String desc; | ||
|
||
@JsonCreator | ||
public static RoomType getEnumFromValue(String value) { | ||
if (value == null) { | ||
return null; | ||
} | ||
for (RoomType e : values()) { | ||
if (e.name().equals(value)) { | ||
return e; | ||
} else if (e.code.toUpperCase(Locale.ROOT).equals(value.toUpperCase(Locale.ROOT))) { | ||
return e; | ||
} | ||
} | ||
return null; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
...ingpong-api/src/main/java/gg/party/api/user/room/controller/response/LeaveRoomResDto.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
package gg.party.api.user.room.controller.response; | ||
|
||
import lombok.AllArgsConstructor; | ||
import lombok.Getter; | ||
|
||
@AllArgsConstructor | ||
@Getter | ||
public class LeaveRoomResDto { | ||
private String nickname; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
gg-utils/src/main/java/gg/utils/exception/party/RoomNotOpenException.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
package gg.utils.exception.party; | ||
|
||
import gg.utils.exception.ErrorCode; | ||
import gg.utils.exception.custom.NotExistException; | ||
|
||
public class RoomNotOpenException extends NotExistException { | ||
public RoomNotOpenException() { | ||
super(ErrorCode.ROOM_NOT_OPEN.getMessage(), ErrorCode.ROOM_NOT_OPEN); | ||
} | ||
|
||
public RoomNotOpenException(ErrorCode errorCode) { | ||
super(errorCode.getMessage(), errorCode); | ||
} | ||
} |
14 changes: 14 additions & 0 deletions
14
gg-utils/src/main/java/gg/utils/exception/party/RoomNotParticipantException.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
package gg.utils.exception.party; | ||
|
||
import gg.utils.exception.ErrorCode; | ||
import gg.utils.exception.custom.NotExistException; | ||
|
||
public class RoomNotParticipantException extends NotExistException { | ||
public RoomNotParticipantException() { | ||
super(ErrorCode.ROOM_NOT_PARTICIPANT.getMessage(), ErrorCode.ROOM_NOT_PARTICIPANT); | ||
} | ||
|
||
public RoomNotParticipantException(ErrorCode errorCode) { | ||
super(errorCode.getMessage(), errorCode); | ||
} | ||
} |
11 changes: 11 additions & 0 deletions
11
gg-utils/src/main/java/gg/utils/exception/party/UserNotFoundException.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
package gg.utils.exception.party; | ||
|
||
import gg.utils.exception.ErrorCode; | ||
import gg.utils.exception.custom.NotExistException; | ||
|
||
public class UserNotFoundException extends NotExistException { | ||
public UserNotFoundException() { | ||
super(ErrorCode.USER_NOT_EXIST.getMessage(), ErrorCode.USER_NOT_EXIST); | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static 처음보네요 음 뭐 없으면 안된다니 참고하겠습니다