Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AreSain
reviewed
Mar 4, 2024
AreSain
reviewed
Mar 4, 2024
gg-pingpong-api/src/main/java/gg/party/api/user/room/controller/RoomController.java
Outdated
Show resolved
Hide resolved
AreSain
reviewed
Mar 4, 2024
gg-pingpong-api/src/main/java/gg/party/api/user/room/controller/RoomController.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #677 +/- ##
============================================
+ Coverage 74.16% 74.22% +0.05%
+ Complexity 737 733 -4
============================================
Files 166 164 -2
Lines 3178 3162 -16
Branches 340 337 -3
============================================
- Hits 2357 2347 -10
+ Misses 677 674 -3
+ Partials 144 141 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JaBeast
previously approved these changes
Mar 4, 2024
- 참여 인원 0명 됐을 때 저장 안 되는 에러 수정 - 유저의 참여 방 여러 개 일 때 다른 방에서 나가는 에러 수정
yes-ee
reviewed
Mar 5, 2024
...gpong-api/src/main/java/gg/party/api/user/room/controller/response/LeaveRoomResponseDto.java
Outdated
Show resolved
Hide resolved
yes-ee
approved these changes
Mar 5, 2024
JaBeast
reviewed
Mar 5, 2024
| @@ -1,6 +1,7 @@ | |||
| package gg.data.party; | |||
|
|
|||
| import java.time.LocalDateTime; | |||
| import static gg.utils.exception.BusinessChecker.*; | |||
| import static gg.utils.exception.ErrorCode.*; | |||
There was a problem hiding this comment.
static 처음보네요 음 뭐 없으면 안된다니 참고하겠습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
💡Issue 번호